fix: switch updatedAt to datetime_immutable

maelgangloff · Sep 4, 2024 · 7117330 · 7117330
1 parent b4aef61
commit 7117330
Show file tree

Hide file tree

Showing 6 changed files with 40 additions and 7 deletions.
diff --git a/migrations/Version20240904162520.php b/migrations/Version20240904162520.php
@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DoctrineMigrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+/**
+ * Auto-generated Migration: Please modify to your needs!
+ */
+final class Version20240904162520 extends AbstractMigration
+{
+    public function getDescription(): string
+    {
+        return '';
+    }
+
+    public function up(Schema $schema): void
+    {
+        // this up() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE domain ALTER updated_at TYPE TIMESTAMP(0) WITHOUT TIME ZONE');
+        $this->addSql('COMMENT ON COLUMN domain.updated_at IS \'(DC2Type:datetime_immutable)\'');
+    }
+
+    public function down(Schema $schema): void
+    {
+        // this down() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE domain ALTER updated_at TYPE DATE');
+        $this->addSql('COMMENT ON COLUMN domain.updated_at IS \'(DC2Type:date_immutable)\'');
+    }
+}
diff --git a/src/Controller/DomainRefreshController.php b/src/Controller/DomainRefreshController.php
@@ -54,7 +54,7 @@ public function __invoke(string $ldhName, KernelInterface $kernel): Domain
         if (null !== $domain
             && !$domain->getDeleted()
             && ($domain->getUpdatedAt()->diff(new \DateTimeImmutable('now'))->days < 7)
-            && !$this->RDAPService::isToBeWatchClosely($domain, $domain->getUpdatedAt())
+            && !$this->RDAPService::isToBeWatchClosely($domain)
             && !$this->kernel->isDebug()
         ) {
             $this->logger->info('It is not necessary to update the information of the domain name {idnDomain} with the RDAP protocol.', [

diff --git a/src/Entity/Domain.php b/src/Entity/Domain.php
@@ -90,10 +90,10 @@ class Domain
     private Collection $nameservers;
 
     #[ORM\Column(type: Types::DATE_IMMUTABLE)]
-    private ?\DateTimeImmutable $createdAt = null;
+    private ?\DateTimeImmutable $createdAt;
 
-    #[ORM\Column(type: Types::DATE_IMMUTABLE)]
-    private ?\DateTimeImmutable $updatedAt = null;
+    #[ORM\Column(type: Types::DATETIME_IMMUTABLE)]
+    private ?\DateTimeImmutable $updatedAt;
 
     #[ORM\ManyToOne]
     #[ORM\JoinColumn(referencedColumnName: 'tld', nullable: false)]

diff --git a/src/MessageHandler/UpdateDomainsFromWatchlistHandler.php b/src/MessageHandler/UpdateDomainsFromWatchlistHandler.php
@@ -65,7 +65,7 @@ public function __invoke(UpdateDomainsFromWatchlist $message): void
                      ->filter(fn ($domain) => $domain->getUpdatedAt()
                              ->diff(
                                  new \DateTimeImmutable('now'))->days >= 7
-                         || $this->RDAPService::isToBeWatchClosely($domain, $domain->getUpdatedAt())
+                         || $this->RDAPService::isToBeWatchClosely($domain)
                      ) as $domain
         ) {
             $updatedAt = $domain->getUpdatedAt();

diff --git a/src/Scheduler/SendNotifWatchListTriggerSchedule.php b/src/Scheduler/SendNotifWatchListTriggerSchedule.php
@@ -21,7 +21,7 @@ public function getSchedule(): Schedule
     {
         return (new Schedule())
             ->add(
-                RecurringMessage::every('1 day', new ProcessWatchListsTrigger()),
+                RecurringMessage::every('1 hour', new ProcessWatchListsTrigger()),
             )
             ->stateful($this->cache);
     }

diff --git a/src/Service/RDAPService.php b/src/Service/RDAPService.php
@@ -99,7 +99,7 @@ public function __construct(private HttpClientInterface $client,
      *
      * @throws \Exception
      */
-    public static function isToBeWatchClosely(Domain $domain, \DateTimeImmutable $updatedAt): bool
+    public static function isToBeWatchClosely(Domain $domain): bool
     {
         $status = $domain->getStatus();
         if (!empty($status) && count(array_intersect($status, self::IMPORTANT_STATUS))) {