Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation discrepancies with paper #8

Open
NeuronAppreciator opened this issue Sep 13, 2024 · 0 comments
Open

Implementation discrepancies with paper #8

NeuronAppreciator opened this issue Sep 13, 2024 · 0 comments

Comments

@NeuronAppreciator
Copy link

Hi,

I'm trying to manually implement this in another language. Can you confirm this codebase is the one that produced the results in "Speech Denoising without Clean Training Data: a Noise2Noise Approach"? There are a few discrepancies I've noticed so far:

  • A model complexity of (45//1.414) would seem to result in 31 encoder channels (and 62 for deeper ones), rather than 32 as described.
  • The complex batchnorm module seems to implement batchnorm separately on real and imaginary components of the complex number, rather than using the whitening approach described in “Deep complex networks"
  • Similarly the masking process seems to multiply real and imaginary components of the spectrogram separately rather than using complex multiplication.

I appreciate any insight you may have about these points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant