From 280cb4e677b76693ccdbf6d379eb442dbb459631 Mon Sep 17 00:00:00 2001 From: Charpa <102919164+jbcaron@users.noreply.github.com> Date: Thu, 19 Dec 2024 13:26:00 +0100 Subject: [PATCH] fix: rpc deploy account (#432) --- CHANGELOG.md | 1 + Cargo.lock | 4 ++-- crates/client/devnet/src/lib.rs | 1 - crates/primitives/gateway/src/user_transaction.rs | 4 ---- 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 70fe91764..28e96d487 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ ## Next release +- fix(rpc): fix BroadcastedDeclareTxn V3 in starknet-types-rpc - fix: oracle need condition - fix(block_production): continue pending block now reexecutes the previous transactions - feat(services): reworked Madara services for better cancellation control diff --git a/Cargo.lock b/Cargo.lock index 66a6c5f5d..55cd7ea83 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -8477,7 +8477,7 @@ dependencies = [ [[package]] name = "starknet-types-core" version = "0.1.7" -source = "git+https://github.com/jbcaron/types-rs.git?branch=fork#050be63116750e4ce253a91bfd6aa4bb8db7fe43" +source = "git+https://github.com/jbcaron/types-rs.git?branch=fork#570eb3eb21d64afef90242c9e5132c1e58b6b62c" dependencies = [ "lambdaworks-crypto", "lambdaworks-math", @@ -8490,7 +8490,7 @@ dependencies = [ [[package]] name = "starknet-types-rpc" version = "0.7.1" -source = "git+https://github.com/jbcaron/types-rs.git?branch=fork#050be63116750e4ce253a91bfd6aa4bb8db7fe43" +source = "git+https://github.com/jbcaron/types-rs.git?branch=fork#570eb3eb21d64afef90242c9e5132c1e58b6b62c" dependencies = [ "serde", "starknet-types-core 0.1.7 (git+https://github.com/jbcaron/types-rs.git?branch=fork)", diff --git a/crates/client/devnet/src/lib.rs b/crates/client/devnet/src/lib.rs index 0f71a655b..1be4f1929 100644 --- a/crates/client/devnet/src/lib.rs +++ b/crates/client/devnet/src/lib.rs @@ -376,7 +376,6 @@ mod tests { account_deployment_data: vec![], nonce_data_availability_mode: DaMode::L1, fee_data_availability_mode: DaMode::L1, - version: starknet_types_rpc::Version::X3, }); let res = chain.sign_and_add_declare_tx(declare_txn, sender_address).unwrap(); diff --git a/crates/primitives/gateway/src/user_transaction.rs b/crates/primitives/gateway/src/user_transaction.rs index d92bfaac1..6e0acab2b 100644 --- a/crates/primitives/gateway/src/user_transaction.rs +++ b/crates/primitives/gateway/src/user_transaction.rs @@ -196,10 +196,6 @@ impl From for BroadcastedDeclareTxnV3 { contract_class: transaction.contract_class.into(), paymaster_data: transaction.paymaster_data, account_deployment_data: transaction.account_deployment_data, - version: match transaction.is_query { - true => starknet_types_rpc::Version::X100000000000000000000000000000003, - false => starknet_types_rpc::Version::X3, - }, } } }