[paused] feat: snos job #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| fn max_verification_attempts(&self) -> u64 { | ||
| todo!() | ||
| // TODO: isn't 10 a lot? | ||
| 10 |
There was a problem hiding this comment.
ya if there's no verification then 10 would be a lot :)
| } | ||
|
|
||
| fn verification_polling_delay_seconds(&self) -> u64 { | ||
| todo!() | ||
| // TODO: what is an average run time for SNOS? | ||
| 60 |
There was a problem hiding this comment.
we don't know the runtime yet but in the current implementation looks like we run in synchronously so verification delay can be like 1s
|
Hi @apoorvsadana , I just want to know if there are any plans for SNOS. I've noticed that this PR has been on hold for a while. |
Hey @Tranduy1dol - this PR is on hold until the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⏸ On hold
This PR is currently paused until the snos repository has been updated (since the way to run Snos in the context of Madara will change a lot and we don't have any spec/design yet).
Resolves: #11
Added
SnosJobStateJob::DummyState- used as a replacement until we can import the structureBlockifierStateAdapterfrom Madara. Currently not possible dues to conflicting dependencies versions between Snos <=> Madara <=> Cairo-vm. (It may not be needed at all to import that depending on the next updates from snos, their goal is to make it easier to run the Snos in the context of Madara)HttpRpcClientto ourConfigfor RPC requests to L1/Madara (gas price & snos input at the moment)conversions&timeutils functions