feat: state update job #23

akhercha · 2024-06-21T13:23:34Z

Resolves: #13
Follow-up issues: #28 #29

Added

State update job implementation + tests
ethereum & starknet settlement clients

Comments

TODO in a follow-up task: Implement the required arguments for update_state_calldata and update_state_blobs.

unstark · 2024-06-22T14:27:14Z

crates/orchestrator/src/jobs/state_update_job/mod.rs

+                MaybePendingStateUpdate::Update(state_update) => state_update,
+            };
+            // TODO: how to build the required arguments?
+            settlement_client.update_state_calldata(vec![], vec![], 0).await?;


You probably can reuse https://github.com/karnotxyz/madara-orchestrator/blob/cb74280a520b73c1b905461373db487a54731aef/crates/prover-services/gps-fact-checker/src/fact_node.rs#L49 but you need the right leaf (not the root)

And the size of the onchain part is len(program_output) - main part size https://github.com/starkware-libs/cairo-lang/blob/efa9648f57568aad8f8a13fbf027d2de7c63c2c0/src/starkware/starknet/core/os/output.cairo#L198

crates/orchestrator/src/jobs/state_update_job/mod.rs

crates/settlement-clients/ethereum/src/clients/interfaces/validity_interface.rs

crates/settlement-clients/ethereum/src/config.rs

crates/settlement-clients/ethereum/src/lib.rs

crates/orchestrator/src/jobs/state_update_job/mod.rs

crates/orchestrator/src/jobs/types.rs

…on check

crates/orchestrator/src/jobs/state_update_job/mod.rs

crates/settlement-clients/ethereum/src/lib.rs

crates/orchestrator/src/jobs/state_update_job/mod.rs

crates/orchestrator/src/database/mongodb/mod.rs

apoorvsadana · 2024-07-01T17:31:04Z

crates/orchestrator/src/tests/jobs/state_update_job/mod.rs

+
+#[rstest]
+#[tokio::test]
+async fn test_create_job() {


can we add a test case for retries as well? feel free to create an issue if you want it to be addresses in a new PR

Created an issue here:
#30

crates/settlement-clients/ethereum/src/lib.rs

unstark · 2024-07-01T19:17:47Z

crates/settlement-clients/starknet/src/lib.rs

+    /// Wait for a pending tx to achieve finality
+    async fn wait_for_tx_finality(&self, tx_hash: &str) -> Result<()> {
+        let mut retries = 0;
+        // TODO: time to wait should be configurable in SettlementConfig?


apoorvsadana · 2024-07-02T16:18:07Z

crates/orchestrator/src/database/mongodb/mod.rs

+        job_doc.insert("external_id", external_id);
+        job_doc.insert("status", bson::to_bson(&new_status)?);
+        job_doc.insert("metadata", bson::to_document(&metadata)?);


can we just take the job item only because that will have all the other stuff updated already

* feat(state_update_job): Init work * feat(state_update_job): Updated configurations with rpc_url & providers * feat(state_update_job): StarknetValidityContract added * feat(state_update_job): saving state * feat(state_update_job): Cleanup * feat(state_update_job): conversions * feat(state_update_job): added test data * feat(state_update_job): moonsoong fork * feat(state_update_job): cleanup * feat(state_update_job): cleaning * feat(state_update_job): Cleaning up * feat(state_update_job): Update * feat(state_update_job): Quick update * feat(state_update_job): Cleaning/Renaming tests files * feat(state_update_job): vscode files ignored * feat(state_update_job): * feat(state_update_job): starknet settlement * feat(state_update_job): * feat(state_update_job): fixing tests * feat(state_update_job): Fixed tests * feat(state_update_job): * feat(state_update_job): Validating blocks to settle * feat(state_update_job): verify inclusion * feat(state_update_job): Docs * feat(state_update_job): Quick refinements * feat(state_update_job): Refactoring + tests * feat(state_update_job): should_panic quick update * feat(state_update_job): Added reason for rejected status * feat(state_update_job): More context for piltover contract * feat(state_update_job): Added comment about zaun impl * feat(state_update_job): Added test case * feat(state_update_job): external_id = last_tx_hash executed + verify inclusion * feat(state_update_job): Restored lcov.info * feat(state_update_job): propagating error * feat(state_update_job): SettingsProvider used * feat(state_update_job): Empty: error * feat(state_update_job): Updated TODO * feat(state_update_job): Linting * feat(state_update_job): Restricted state update type + Verify inclusion check * feat(state_update_job): verify inclusion tx * feat(state_update_job): Fixes from review * feat(state_update_job): Sorting imports * feat(state_update_job): Refinement * feat(state_update_job): Fixed tests * feat(state_update_job): Simple comments for context * feat(state_update_job): Updating job * feat(state_update_job): Fixes from code review * feat(state_update_job): Fixes from review * feat(state_update_job): Fix from review * feat(state_update_job): Fixed linter

akhercha added 21 commits June 20, 2024 11:26

feat(state_update_job): Init work

c2d23eb

feat(state_update_job): Updated configurations with rpc_url & providers

f9d95ac

feat(state_update_job): StarknetValidityContract added

dcb2e0b

feat(state_update_job): saving state

543acdb

feat(state_update_job): Cleanup

e8a7793

feat(state_update_job): conversions

eec4f3c

feat(state_update_job): added test data

3423d5f

feat(state_update_job): moonsoong fork

16273ae

feat(state_update_job): cleanup

3c78a25

feat(state_update_job): cleaning

1056b16

feat(state_update_job): Cleaning up

cd73e7a

feat(state_update_job): Update

a388bc9

feat(state_update_job): Quick update

02fa383

feat(state_update_job): Cleaning/Renaming tests files

29a6296

feat(state_update_job): vscode files ignored

0484ab5

feat(state_update_job):

aae2f80

feat(state_update_job): starknet settlement

7ae5b44

feat(state_update_job):

89fdff8

feat(state_update_job): fixing tests

fd9893d

feat(state_update_job): Fixed tests

b128bd8

feat(state_update_job):

d9e5221