Skip to content

Commit

Permalink
better comments for nodejs20/21 portfile
Browse files Browse the repository at this point in the history
  • Loading branch information
i3roly committed Nov 26, 2024
1 parent 2c999c4 commit 3b64810
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions devel/nodejs20/Portfile
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ if { ${os.platform} eq "darwin" && ${os.major} < 15 } {
if {[string match *clang* ${configure.compiler}]} {
configure.cxx-append -Wno-error=enum-constexpr-conversion

# for older macs it seems nodejs21 requires the packaged libuv,
# for older macs it seems nodejs20+ requires the packaged libuv,
# unlike earlier versions. the flag below ensures the libuv
# packaged with nodejs21 can be used
# packaged with nodejs20+ can be used
configure.cxx-append -Wno-error=incompatible-function-pointer-types
}

Expand Down
4 changes: 2 additions & 2 deletions devel/nodejs21/Portfile
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ if { ${os.platform} eq "darwin" && ${os.major} < 15 } {
if {[string match *clang* ${configure.compiler}]} {
configure.cxx-append -Wno-error=enum-constexpr-conversion

# for older macs it seems nodejs21 requires the packaged libuv,
# for older macs it seems nodejs20+ requires the packaged libuv,
# unlike earlier versions. the flag below ensures the libuv
# packaged with nodejs21 can be used
# packaged with nodejs20+ can be used
configure.cxx-append -Wno-error=incompatible-function-pointer-types
}

Expand Down

0 comments on commit 3b64810

Please sign in to comment.