Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Formatting broken on cargo workspaces #243

Open
GUIpsp opened this issue Aug 24, 2024 · 2 comments
Open

Regression: Formatting broken on cargo workspaces #243

GUIpsp opened this issue Aug 24, 2024 · 2 comments

Comments

@GUIpsp
Copy link

GUIpsp commented Aug 24, 2024

#217 unfortunately causes the rust formatting hook to break on cargo workspaces.

See https://github.com/GUIpsp/language-formatters-pre-commit-hooks-bug-demo for a minimal repro. Just clone and pre-commit run --all

@macisamuele
Copy link
Owner

@GUIpsp sorry for the very large lag in here.

What is the issue that cargo workspaces are providing to the repo? what is the expectation that you would have?

By checking the repo (did not try to run pre-commits on it), I see that it does not adhere to a rust workspace, which makes me think that the repo per se is somewhat inconsistent with the expectations of a Rust repository.

At the same time I would be interested to hear more about the expectations you might have to determine if there could be some variations that can be done to smooth the experience

@GUIpsp
Copy link
Author

GUIpsp commented Oct 24, 2024

Hey, no worries about the response time.

I am not sure what you mean by "It doesn't adhere to a rust workspace" - there is a root Cargo.toml with the workspace.members element - and indeed cargo build works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants