Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gem version pins are preventing use in Rails 3.2 #18

Open
ijcd opened this issue Feb 24, 2012 · 4 comments
Open

gem version pins are preventing use in Rails 3.2 #18

ijcd opened this issue Feb 24, 2012 · 4 comments

Comments

@ijcd
Copy link

ijcd commented Feb 24, 2012

These are making the gem hard to install (I have a gem that depends on SuperModel). I think it should work if we upgrade, but it seems there are a lot of tests that need to be written to confirm this, eh?

if s.respond_to? :specification_version then
current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
s.specification_version = 3

if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
  s.add_runtime_dependency(%q<activemodel>, [">= 3.0.0"])
else
  s.add_dependency(%q<activemodel>, ["~> 3.0.0"])
end

else
s.add_dependency(%q, ["~> 3.0.0"])
end

@maccman
Copy link
Owner

maccman commented Feb 24, 2012

Pull requests always welcome.

@ijcd
Copy link
Author

ijcd commented Feb 24, 2012

Ok, good to know. I'll share what I come up with. I got trapped under this pin and couldn't tell how active the project was.

@jeffshantz
Copy link

A pull request was submitted in #23 7 months ago. :)

@quarklemotion
Copy link
Contributor

#23 was merged a while back, so this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants