Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make [Try]IntoCtx borrow instead of copying #47

Closed
wants to merge 4 commits into from
Closed

Make [Try]IntoCtx borrow instead of copying #47

wants to merge 4 commits into from

Commits on Nov 2, 2018

  1. Borrow instead of copying in IntoCtx, TryIntoCtx, Cwrite, Pwrite

    @willglynn
    willglynn committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    749f752 View commit details
    Browse the repository at this point in the history

  2. Add a test which complains about unaligned field accesses

    @willglynn
    willglynn committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    ad6df6e View commit details
    Browse the repository at this point in the history

  3. Serialize #[repr(packed)] structs by copying out their fields 

    This assumes that #[repr(packed)] types are also Copy, which is a thing
we can't verify in this context. At least we're in good company: the
built-in #[derive]s all require #[derive(Copy)] for packed structs.

Further discussion:
  m4b#46 (comment)
    @willglynn
    willglynn committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    2a73c26 View commit details
    Browse the repository at this point in the history

  4. Change iowrite() to also take a reference

    @willglynn
    willglynn committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    efc16f3 View commit details
    Browse the repository at this point in the history