-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Leak issue #164
Comments
Thanks, thats true, this is a memory leak, can you make PR ? |
asifbilal786
added a commit
to asifbilal786/MZFormSheetPresentationController
that referenced
this issue
Nov 26, 2018
I have created Pull Request for this issue. Please accept this. |
asifbilal786
added a commit
to asifbilal786/MZFormSheetPresentationController
that referenced
this issue
Nov 26, 2018
Fixed m1entus#164 (Memory Leak issue)
Don't see Pull Request, you probably only have added commit to your repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi
First thanks for the great library. It's really useful.
But I am facing the memory leaks when using this library. I have debug into the code and came to know that this code is causing memory leak.
self.propertyAnimator = [[UIViewPropertyAnimator alloc] initWithDuration:1.0 curve:UIViewAnimationCurveLinear animations:^{ self.blurBackgroundView.effect = nil; }];
To resolve it I have changed it to weak self as instructed by Apple to avoid any memory issue.
__weak MZFormSheetPresentationController *weakSelf = self; self.propertyAnimator = [[UIViewPropertyAnimator alloc] initWithDuration:1.0 curve:UIViewAnimationCurveLinear animations:^{ weakSelf.blurBackgroundView.effect = nil; }];
Please update the pod with resolution of this issue.
Thanks!!!
The text was updated successfully, but these errors were encountered: