Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Jupyter Notebook version 7 #100

Merged
merged 6 commits into from
Aug 20, 2023

Conversation

m-rossi
Copy link
Owner

@m-rossi m-rossi commented Aug 20, 2023

New feature/Bug fix description

Jupyter Notebook version 7 changed quite a lot under the hood and a few adjustments are needed in jupyter-docx-bundler

Related issues

Close #99

Checklist

  • Tests have passed
  • New code is covered with tests

@m-rossi m-rossi added the bug label Aug 20, 2023
@m-rossi m-rossi added this to the 0.4.0 milestone Aug 20, 2023
@m-rossi m-rossi self-assigned this Aug 20, 2023
@m-rossi m-rossi linked an issue Aug 20, 2023 that may be closed by this pull request
@m-rossi m-rossi marked this pull request as draft August 20, 2023 11:13
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (8519db2) 97.22% compared to head (8425d83) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   97.22%   97.21%   -0.02%     
==========================================
  Files           6        6              
  Lines         540      502      -38     
==========================================
- Hits          525      488      -37     
+ Misses         15       14       -1     
Files Changed Coverage Δ
jupyter_docx_bundler/__init__.py 100.00% <ø> (+4.16%) ⬆️
jupyter_docx_bundler/tests/test_bundler.py 100.00% <ø> (ø)
jupyter_docx_bundler/tests/test_converters.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-rossi m-rossi marked this pull request as ready for review August 20, 2023 12:06
@m-rossi m-rossi merged commit 79ca37f into main Aug 20, 2023
29 checks passed
@m-rossi m-rossi deleted the 99-incompatibility-to-jupyter-notebook-version-7 branch August 20, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility to Jupyter notebook version 7
1 participant