BUG: AWS S3 write closer does not wait for the inner goroutine to close

[peczenyj]

Hello

By using the awss3 store, we note that in the shutdown of our application we do not upload the remaining data.

Checking the reason, we discover that if we add a sleep of some seconds, it works.

This happens because this goroutine:

cloudstorage/awss3/store.go

Line 455 in 4b211b8

go func() {

does not have any kind of synchronization / waitgroup etc and during a shutdown, the write closer Close method returns but we do not finish the actual upload in background.

I see that the azure package had a wrapper thar uses an errgroup and this ensure that azure objects close properly. the same must be done in awss3