Refactor Window Manager interaction #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfgit
force-pushed
the
work/gfgit/refactor_wm_interaction
branch
from
2cc8539
to
e7f3140
Compare
This was referenced Mar 26, 2024
Closed
This is an abstract interface to operate windows and workspaces
- Move WindowProperty enum to lxqttaskbartypes.h
This model will manage the tasks shown
Also use it to get window icon
- Don't rely on global screen coordinates - This will be needed for future Wayland port, Where we don't have global screen coordinates - Keep compatible behavior on X11
This new window propery flag is needed to notify geometry changes
- It is now a global instance
tsujan
requested changes
May 11, 2024
tsujan
reviewed
May 11, 2024
tsujan
reviewed
May 11, 2024
tsujan
reviewed
May 11, 2024
tsujan
reviewed
May 12, 2024
|
There is basic issue with this PR and the ones based upon. If no lxqt-panel is installed and People without an existing installation of lxqt-panel got |
|
Confirming @stefonarch's surprising observation. |
|
@gfgit Do you have some time to look at the remaining issues? |
|
Hi, I'm back. Compile issues should be fixed by latest commit |
This reverts commit b0e54b8.
|
@tsujan I've reverted commit regarding panel positioning. It only affects Wayland which is not yet merged. |
Confirmed. I see that now there are 6 files instead of the previous 4: Will do some test later on X11. |
Under Wayland, Qt's global coordinates are actually local and calculated relative to the window. Please resolve the conflicts with the master branch. |
|
@tsujan Conflicts are fixed now |
Thanks! I'll continue reviewing tomorrow. |
|
@gfgit I get compiling errors now: |
|
Hi, it may be a left over from the merge conflict. Does it build fine if you remove the line?
Il 6 giugno 2024 13:38:09 CEST, Standreas ***@***.***> ha scritto:
…
@gfgit I get compiling errors now:
```
[ 28%] Building CXX object plugin-fancymenu/CMakeFiles/fancymenu.dir/lxqtfancymenu.cpp.o
/tmp/makepkg/lxqt-panel-git/src/lxqt-panel/plugin-desktopswitch/desktopswitch.cpp: In constructor 'DesktopSwitch::DesktopSwitch(const ILXQtPanelPluginStartupInfo&)':
/tmp/makepkg/lxqt-panel-git/src/lxqt-panel/plugin-desktopswitch/desktopswitch.cpp:55:5: error: class 'DesktopSwitch' does not have any field named 'mDesktops'
55 | mDesktops(nullptr),
```
--
Reply to this email directly or view it on GitHub:
#2041 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Yes, thanks. |
tsujan
reviewed
Jun 6, 2024
tsujan
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
I can't say that my review is complete — it's done in separate stages, and the code has been changed after each of them — but, as far as my free time allowed, I found some problems that are fixed now. IMO, this PR has waited enough, considering that 2 other works depend on it.
So, GTM.
|
Thanks! |
Thank you for doing this great job! Please also rebase your other PR if it needs that. I hope we could merge it and @marcusbritanicus's PR soon because we need more testers. |
|
I am having a rather strange compilation issue: I have not seen anyone else complain about it, so it might be a problem in my setup. But it would be nice to figure out the issue. Edit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #2029 rebased on latest master
Main differences with initial idea:
ILXQtTaskbarAbstractBackendis stored globally insideLXQtPanelApplication(infact I should drop "taskbar" part of the name)TODO: port other plugins which currently directly use X11 to use this abstract interface