Handle "Not Charging" state in battery indicator #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the battery is has reached the target charge level, some devices use the status "Not Charging". LXpanel should not interpret this to mean "Discharging", but rather the same as "Full".
|
At least this is needed on Fedora (kernel). I have already applied this as: https://src.fedoraproject.org/rpms/lxpanel/c/a8d4974ada8fa1b1300560a70b435819155c2fad |
embedeo
approved these changes
Aug 29, 2023
|
Still I would appreciate it if this is merged. |
|
Checking for "Not Charging" in a function called battery_is_charging() would be extremely confusing to me. I suggest just checking for not equal to "Discharging" instead. In your commit message (where there is a stray "is", by the way), you should then add a list of the valid values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the battery is has reached the target charge level, some devices use the status "Not Charging". LXpanel should not interpret this to mean "Discharging", but rather the same as "Full".