Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make three colored circles a bit smaller and with more spacing #516

Closed
ghost opened this issue Aug 8, 2020 · 8 comments
Closed

Make three colored circles a bit smaller and with more spacing #516

ghost opened this issue Aug 8, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Aug 8, 2020

Small GUI suggestion:

I'm sure they can't be identical to macOS own design, but I suggest to make the three coloured buttons a little smaller (in relation to the window thumbnail size) and more padding between them and the thumbnail edge.

@ghost ghost added the enhancement New feature or request label Aug 8, 2020
@lwouis
Copy link
Owner

lwouis commented Aug 11, 2020

Hey @mindfulsource! Thanks for sharing this feedback!

Actually I agree that they would be easier to understand if they were "identical to macOS own design". Here is some background on how they are made currently, and why they are not 1-for-1 with the system icons.

I went with this for simplicity, but as an improvement, it makes sense to improve on these icons. A worry here would be that they scale with font size, as the current implementation does. That kind of rules out using images.

Does anybody know if they exist some copyleft license vector images of macOS standard icons?

Also ideally in scope for this ticket is adding a mouse-hover and mouse-down behavior to these 3 icons.

@lwouis
Copy link
Owner

lwouis commented Aug 11, 2020

IP

I'm not worried about this. I think Apple is fine with apps using icons from their OS, since they make that an option in the APIs. That's not a concern.

SVG

macOS has no native support for SVG. This means I would need a way to convert icons from SVG to bitmap images either at compile-time, or run-time. Currently, I do this at compile-time since I want original assets to exist as SVG for scalability purpose, and to be future-proof when we need to support higher resolutions.

Given how ubiquitous these icons are, there must be some SVG version of them available on some website somewhere. Anybody aware of such link?

@lwouis
Copy link
Owner

lwouis commented Aug 11, 2020

Yes please share SVG assets. This is the format of choice for this project as it is non-proprietary.

@lwouis
Copy link
Owner

lwouis commented Aug 12, 2020

Thanks for sharing all the assets!

I checked them, and it's not 1-for-1 I believe. I notice that the colors are not exactly like on my system (macOS 10.15.5 (19F101)). Also the pressed icons are incorrect on a few regards, but that's not an issue since I think I can just obscure the hover ones (I think that's what macOS does).

It's still an improvement compared to the current ones, that for sure.

@lwouis
Copy link
Owner

lwouis commented Aug 26, 2020

Noteworthy: Apple has Sketch/Photoshop files available here. It does not contain a hovered version of the window controls though

@lwouis
Copy link
Owner

lwouis commented Aug 26, 2020

@mindfulsource I said "It does not contain a hovered version", not "it contains a non-hover version". Your git repo does, but their downloadable assets don't. My point was that their assets are lacking. I'll use yours 👍

@lwouis
Copy link
Owner

lwouis commented Aug 26, 2020

I investigated conversion of SVG to PNG. For documentation sakes, here are 3 versions in 24x24 of the close button icon.

Software PNG output
ImageMagick close-imagemagik
Inkscape close-inkscape
Sketch close-sketch

I'm going to go with Inkspace as I think it has the sharpest results.

Edit: I think github uploads re-compress images, so the differences can't be observed.
Here is a zip with the 3 versions.

@lwouis
Copy link
Owner

lwouis commented Aug 26, 2020

I implemented this. It will be included in the next release. @mindfulsource note that I made a separate commit with you as the author, to mark your contribution in the commit history. This will add you to the list of contributors in the app, the website, and on github.

Also note that I corrected the colors a bit in another commit. You may want to cherry-pick those changes in your git repo.

@lwouis lwouis closed this as completed in 3ddedff Aug 27, 2020
lwouis pushed a commit that referenced this issue Aug 27, 2020
# [6.0.0](v5.3.0...v6.0.0) (2020-08-27)

### Bug Fixes

* alt-tab own windows were not shown in alt-tab (closes [#555](#555)) ([8bcbc04](8bcbc04))
* clicking the main window would steal focus ([de02e5b](de02e5b))
* display firefox develop edition fullscreen windows (closes [#558](#558)) ([3250d37](3250d37))
* guarantee alt-tab window is always up-to-date on display ([be4c5f1](be4c5f1))
* ignore zombie processes ([50c8c82](50c8c82))
* moving some of the preferences sliders was very laggy ([a552c4c](a552c4c))
* shortcuts stop working if active app is quit (closes [#557](#557)) ([023561d](023561d))

### Features

* display quickly even with many open windows (closes [#171](#171)) ([da16a0b](da16a0b))
* improve the 3 colored buttons when hovering (closes [#516](#516)) ([3ddedff](3ddedff))
* update chinese localization ([e150a9a](e150a9a))

### Performance Improvements

* alt-tab appears quicker when summoned ([c2bb896](c2bb896))
* main window appears (a few frames) faster on trigger ([2bc09e6](2bc09e6))

### BREAKING CHANGES

* the window thumbnails are now updated *after* the UI is shown. AltTab will first display its window, with the first 3 thumbnails up-to-date, then asynchronously update the rest of the thumbnails one-by-one. This improves the experience of users with lots of windows open.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant