Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons are randomly smaller than others #1248

Closed
simoheinonen opened this issue Nov 23, 2021 · 3 comments
Closed

Some icons are randomly smaller than others #1248

simoheinonen opened this issue Nov 23, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@simoheinonen
Copy link

Describe the bug

Some icons are smaller than others when doing cmd+tab. Happens pretty consistently but not all the time so not sure if this a bug or some kind of feature I don't understand.

Screenshots / video

PXL_20211123_151138679

Steps to reproduce the bug

macOS Monterey 12.0
AltTab 6.28.0

Screenshot 2021-11-23 at 17 12 24
Screenshot 2021-11-23 at 17 15 36

@simoheinonen simoheinonen added the bug Something isn't working label Nov 23, 2021
@lwouis
Copy link
Owner

lwouis commented Nov 23, 2021

I set my preferences to the same values you show on the screenshot, and it works correctly for me.

It seems like a bug in the layout logic. The layout logic is very complex, as you can see from the available options offered to customize. I'm noticing that you have the window titles set to 10px here, though it doesn't show, because you set the min width in row to 0% for instance.

I'm afraid I can't offer much for now. I think I approached with too much open-ness when I made the layout system. I'm hoping it can be remade to focus on the common use cases like yours (big app icons, no thumbnail, no title). Most people (rightfully) don't understand how the various parameters interact.

So short-term, please try to play with the options. Maybe some variation will be more stable / not have the issue. More long-term, proper solution will happen we we rework the appearance preferences, and the layout system.

I'll close this ticket for now as I consider it will be subsumed by tickets such as #351

@lwouis lwouis closed this as completed Nov 23, 2021
@simoheinonen
Copy link
Author

Making "Window min width in row" over 0% fixed it for me!

@lwouis
Copy link
Owner

lwouis commented Nov 24, 2021

@simoheinonen thank you for reporting the workaround which worked for you! I will push a quick short-term fix to avoid users being able to set min/max width to 0%. I'm not sure 0% ever makes sense, so forcing at least 1% should avoid this situation, while being a quick workaround to implement in the short-term before more serious reworks.

lwouis pushed a commit that referenced this issue Dec 1, 2021
# [6.29.0](v6.28.0...v6.29.0) (2021-12-01)

### Bug Fixes

* only make network calls to appcenter when necessary (closes [#1265](#1265)) ([79c2906](79c2906))
* prevent setting min width to 0% in preferences (see [#1248](#1248)) ([467736c](467736c))

### Features

* add apple screen sharing to default blacklist ([#1258](#1258)) ([d4780f6](d4780f6))
* add vmware fusion to default blacklist (closes [#1258](#1258)) ([17f98b5](17f98b5))
zacharee pushed a commit to zacharee/alt-tab-macos that referenced this issue Dec 11, 2021
zacharee pushed a commit to zacharee/alt-tab-macos that referenced this issue Dec 11, 2021
# [6.29.0](lwouis/alt-tab-macos@v6.28.0...v6.29.0) (2021-12-01)

### Bug Fixes

* only make network calls to appcenter when necessary (closes [lwouis#1265](lwouis#1265)) ([79c2906](lwouis@79c2906))
* prevent setting min width to 0% in preferences (see [lwouis#1248](lwouis#1248)) ([467736c](lwouis@467736c))

### Features

* add apple screen sharing to default blacklist ([lwouis#1258](lwouis#1258)) ([d4780f6](lwouis@d4780f6))
* add vmware fusion to default blacklist (closes [lwouis#1258](lwouis#1258)) ([17f98b5](lwouis@17f98b5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants