Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic config line support #23

Open
func0der opened this issue Feb 7, 2021 · 5 comments
Open

Generic config line support #23

func0der opened this issue Feb 7, 2021 · 5 comments

Comments

@func0der
Copy link

func0der commented Feb 7, 2021

Hey and thanks for the module.

Since your times to work on this seems limited, why do not we not include a parameter for all unsupported config lines for the /etc/opendkim.conf file.

This way you/the community does not have to open a pr for every parameter out there and the module gets more future proof.

It could be a simple array lines, that are put out into the config file.
Alternatively the template parameter could be made configurable and people could just add their own config files templates with those lines already defined.

@lvicainne
Copy link
Owner

Hi !
Yes, I like your proposal ! :-)
But, maybe did you already noticed some missing parameters ?!
kr

@func0der
Copy link
Author

func0der commented Feb 16, 2021

Yep, basics like SignatureAlgorithm or MinimumKeyBits.
Maybe they are new parameters that just appeared in a later version than the one that was recent when you created the module.
But they are pretty important to harden security nower days.

@dgoldsmith
Copy link

Also SendReports, ReportsAddress for example. Plus a number of the options are in the template erb file statically commented out. They need to exist as class params with default values so they are not included but they do get included if custom values are provided.

@Kritzefitz
Copy link

The MTA parameter is also missing.

lvicainne added a commit that referenced this issue May 27, 2022
@cruelsmith
Copy link
Contributor

With #35 the parameter opendkim::additional_options has been added. These will be added into the /etc/opendkim.conf. See https://github.com/lvicainne/puppet-opendkim/pull/35/files#diff-fad50a39577733382b5f4c6a98ba3ac1841ae115bc23d9975140726dca5d3524R153-R165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants