Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental dependencies #62

Open
v4hn opened this issue Oct 5, 2013 · 2 comments
Open

incremental dependencies #62

v4hn opened this issue Oct 5, 2013 · 2 comments

Comments

@v4hn
Copy link
Member

v4hn commented Oct 5, 2013

Some configure options / dependencies only become available
in case the user selected some other option before (e.g. Xpm image support
in nethack doesn't work without libX11 support).

This does not necessarily require a change in our codebase, but we need a unified way
to handle these cases and "(select only when also XYZ)" in the description is not adequate at all.

Is something like the following supported at the moment for DEPENDS/CONFIGURE and do we want this?
@sofar mentioned that there should be no logic in CONFIGURE/DEPENDS...

if selected_dependency ABC; then
   optional_dependency EFG "--enable-EFG" "--disable-EFG" "EFG support"
fi
@cavalier38
Copy link
Member

DEPENDS can't have logic as it would break the depends tree.

An alternative would be to support a list of modules. This can be used for both batch and incremental depends.

for batch depends:

optional_depends "module1,module2,module3" "--enable-flag" "--disable-flag" "Info"

for incremental depends:

optional_depends "incremental:base" "--enable-inclremental" "--disable-incremental" "Info"
optional_depends "base" "--enable-base" "--disable-base" "Info"

There is a different between , and : this different is mainly for formating the depends question. The implementation of , and : would probably be the same.

@v4hn
Copy link
Member Author

v4hn commented Nov 4, 2013

The logic of `optional_depends "base:incremental" (which way around?) would then automatically add
base as an accepted optional dependency on "y" for the module and the second question will not be asked.

@Ratler, @sofar: what do you guys think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants