Add ignore case for sorting #112
Open
+114
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolved these issues and linting passed locally. |
lukasgeiter
reviewed
Dec 13, 2024
| else: | ||
| key = lambda i: basename(self._get_item_path(i)) | ||
| if ignore_case and sort_type != Meta.SORT_NATURAL: | ||
| key = lambda i: basename(self._get_item_path(i)).casefold() |
There was a problem hiding this comment.
Would it be possible to apply the casefold at a later stage to avoid the code duplication? Further down where the natural sort is handled.
There was a problem hiding this comment.
Let me know what you think of this revision. This is much closer to the original form but just renamed the first occurrence of key to avoid a recursion error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to ignore case for sorting pages.
Similar to previous PR, but added
ignore_caseas an option in theMetaandOptionclasses. Furthermore, modified the_ordermethod so thatignore_caseshould work for natural and standard sorting.