Fix for New() and Empty-field on record struct #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
record struct, theNew()method and theEmptypublic field was removed when cleaning up the baseDef.I parse the
Emptydeclaration, andNew()declaration if present, and inserted before the constructor. So they wouldnt be removed later in the process.I moved some of the methods in the (TYPENAME)_base.cs classes, so that the
Emptyfield could serve as a delimiter on what to keep in the baseDef.I also added some "dummy" test to see that the
EmptyandNew()is generated correctly.