Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time misalignment #2

Open
serkansulun opened this issue Dec 13, 2020 · 0 comments
Open

Time misalignment #2

serkansulun opened this issue Dec 13, 2020 · 0 comments

Comments

@serkansulun
Copy link

The function "split_sequence_with_sentiment" is used to split sequences of annotations to create chunks with a length of 4. When the length of the complete sequence is not a multiple of 4, the remaining values are discarded.

When the MIDI is being split according to these annotation chunks, the discarded values are not taken into consideration, and this would cause a time-shift. When there are only negative or only positive values in a sequence, this is not a problem since the discarded values are at the end of each sequence. But when there are both positive and negative values within a sequence, the sequence is first split to include only positive or only negative values. The values are discarded from the end of these sub-sequences, and these locations are effectively in the middle of the complete sequence. This would certainly be a problem.

Please let me know if I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant