Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up gemma code and models target layers #17

Open
ltoniazzi opened this issue Aug 16, 2024 · 0 comments
Open

Clean up gemma code and models target layers #17

ltoniazzi opened this issue Aug 16, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ltoniazzi
Copy link
Owner

ltoniazzi commented Aug 16, 2024

  • Redundant or missing target layers, for example Phi3 only triggers last output and 1 layer in the mlp block
  • Old code commented for gemma + hardcoded ints + check scale param in config
@ltoniazzi ltoniazzi added enhancement New feature or request good first issue Good for newcomers labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant