From d0540c5d66df76c4d1c810d8f21682740c98f3cf Mon Sep 17 00:00:00 2001
From: Russ Allbery <rra@lsst.org>
Date: Thu, 7 Sep 2023 13:58:54 -0700
Subject: [PATCH] Add mock Kubernetes read methods for more kinds

Add read methods for the Kubernetes object types for which the mock
provided create methods. This is required by the new generic
Kubernetes storage layer in the Nublado lab controller.
---
 changelog.d/20230907_135241_rra_DM_40638b.md |  3 ++
 src/safir/testing/kubernetes.py              | 53 ++++++++++++++++++++
 2 files changed, 56 insertions(+)
 create mode 100644 changelog.d/20230907_135241_rra_DM_40638b.md

diff --git a/changelog.d/20230907_135241_rra_DM_40638b.md b/changelog.d/20230907_135241_rra_DM_40638b.md
new file mode 100644
index 00000000..c18fb365
--- /dev/null
+++ b/changelog.d/20230907_135241_rra_DM_40638b.md
@@ -0,0 +1,3 @@
+### New features
+
+- Add `read_` methods for the Kubernetes object types for which the mock provided `create_` methods (`NetworkPolicy` and `PersistentVolumeClaim`).
diff --git a/src/safir/testing/kubernetes.py b/src/safir/testing/kubernetes.py
index 355eda4d..3a0cb760 100644
--- a/src/safir/testing/kubernetes.py
+++ b/src/safir/testing/kubernetes.py
@@ -1427,6 +1427,31 @@ async def create_namespaced_network_policy(
         name = body.metadata.name
         self._store_object(namespace, "NetworkPolicy", name, body)
 
+    async def read_namespaced_network_policy(
+        self, name: str, namespace: str
+    ) -> V1Pod:
+        """Read a network policy object.
+
+        Parameters
+        ----------
+        name
+            Name of the network policy.
+        namespace
+            Namespace of the network policy.
+
+        Returns
+        -------
+        kubernetes_asyncio.client.V1NetworkPolicy
+            Network policy object.
+
+        Raises
+        ------
+        kubernetes_asyncio.client.ApiException
+            Raised with 404 status if the network policy was not found.
+        """
+        self._maybe_error("read_namespaced_network_policy", name, namespace)
+        return self._get_object(namespace, "NetworkPolicy", name)
+
     # NODE API
 
     async def list_node(self) -> V1NodeList:
@@ -1469,6 +1494,34 @@ async def create_namespaced_persistent_volume_claim(
             namespace, "PersistentVolumeClaim", body.metadata.name, body
         )
 
+    async def read_namespaced_persistent_volume_claim(
+        self, name: str, namespace: str
+    ) -> V1PersistentVolumeClaim:
+        """Read a persistent volume claim.
+
+        Parameters
+        ----------
+        name
+            Name of the persistent volume claim.
+        namespace
+            Namespace of the persistent volume claim.
+
+        Returns
+        -------
+        kubernetes_asyncio.client.V1PersistentVolumeClaim
+            Persistent volume claim object.
+
+        Raises
+        ------
+        kubernetes_asyncio.client.ApiException
+            Raised with 404 status if the persistent volume claim was not
+            found.
+        """
+        self._maybe_error(
+            "read_namespaced_persistent_volume_claim", name, namespace
+        )
+        return self._get_object(namespace, "PersistentVolumeClaim", name)
+
     # POD API
 
     async def create_namespaced_pod(self, namespace: str, body: V1Pod) -> None: