Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDNS Client Subnet (ECS) does not work with resolve #84

Open
I-Knight-I opened this issue Dec 31, 2023 · 0 comments
Open

EDNS Client Subnet (ECS) does not work with resolve #84

I-Knight-I opened this issue Dec 31, 2023 · 0 comments

Comments

@I-Knight-I
Copy link

I-Knight-I commented Dec 31, 2023

EDNS Client Subnet support does not work because the call to resolve in query is malformed.

query
https://github.com/song940/node-dns/blob/b2fdf66a1987e2597ad1b1f0948d0ac5c4acbfe2/index.js#L46

resolve

https://github.com/song940/node-dns/blob/b2fdf66a1987e2597ad1b1f0948d0ac5c4acbfe2/client/udp.js#L9

The fixed call should be:

return resolve(name, type, cls, { clientIp, recursive });

However

I cannot get ECS to work even after this change. Entering the same CDN domain but with one clientIp in Europe and another in the USA, I get the same resolved IP address. This is with both Google's DNS (8.8.8.8) as well as Quad9's ECS-enabled DNS (9.9.9.11).

If I use Resolve-DnsName or dig then the same CDN domain's resolved IP changes depending on the provided subnet / source IP address.

The above is why I've opted to raise an issue and not a PR, as I do not know how to fix the underlying ECS support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant