Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.95.0: test suite is failing #205

Closed
kloczek opened this issue Apr 28, 2022 · 6 comments
Closed

4.95.0: test suite is failing #205

kloczek opened this issue Apr 28, 2022 · 6 comments

Comments

@kloczek
Copy link

kloczek commented Apr 28, 2022

Yeah looks like some stripts are missing

+ /usr/bin/make -O -j48 V=1 VERBOSE=1 -C tests opt
make: Entering directory '/home/tkloczko/rpmbuild/BUILD/lsof-4.95.0/tests'
`cat config.cc`  -I. -I.. `cat config.cflags` LTdnlc.c \
LTlib.o `cat config.xobj` -o LTdnlc
make: Leaving directory '/home/tkloczko/rpmbuild/BUILD/lsof-4.95.0/tests'
make: Entering directory '/home/tkloczko/rpmbuild/BUILD/lsof-4.95.0/tests'
`cat config.cc`  -I. -I.. `cat config.cflags` LTbigf.c \
LTlib.o `cat config.xobj` -o LTbigf
make: Leaving directory '/home/tkloczko/rpmbuild/BUILD/lsof-4.95.0/tests'
make: Entering directory '/home/tkloczko/rpmbuild/BUILD/lsof-4.95.0/tests'
`cat config.cc`  -I. -I.. `cat config.cflags` LTnfs.c \
LTlib.o `cat config.xobj` -o LTnfs
make: Leaving directory '/home/tkloczko/rpmbuild/BUILD/lsof-4.95.0/tests'
make: Entering directory '/home/tkloczko/rpmbuild/BUILD/lsof-4.95.0/tests'
`cat config.cc`  -I. -I.. `cat config.cflags` LTlock.c \
LTlib.o `cat config.xobj` -o LTlock
make: Leaving directory '/home/tkloczko/rpmbuild/BUILD/lsof-4.95.0/tests'
make: Entering directory '/home/tkloczko/rpmbuild/BUILD/lsof-4.95.0/tests'

Optional tests:
LTbigf ... OK
LTdnlc ... /home/tkloczko/rpmbuild/BUILD/lsof-4.95.0/tests found: 100.00%
           OK
LTlock ... lock mismatch: expected W, got " "
           lock mismatch: expected R, got " "
           lock mismatch: expected w, got " "
           lock mismatch: expected r, got " "
LTnfs ... ERROR!!!  test file ./config.LTnfs1555051 not found by lsof
          Hint: the temporary path generated by this test might
          not be on an NFS file system, or this test might be
          unable to create a file on the NFS file system.

          As a work-around use the -p option to specify a path to
          a regular file (not a directory) on an NFS file system
          to which this test will have read access.

          See 00FAQ and 00TEST for more information.
Failed tests: 2
@subnut
Copy link
Contributor

subnut commented May 9, 2022

These tests are called optional for a reason.

Not all optional tests will run in all environments.
What is the environment you are testing this on?

  • Which OS?
  • What file system?
  • Is NFS enabled on that file system?

@subnut
Copy link
Contributor

subnut commented May 9, 2022

See this -

lsof/00TEST

Lines 630 to 688 in 8db8b11

G.4. LTlock, Lock Tests
=======================
This is a test in the optional test group.
This test uses flock() and fcntl() to set and clear file locks,
and measures lsof's ability to report them. The choice of system
lock call is based on the dialect. (There are LT_DIAL_* pre-processor
tests in LTlock.c.)
This test can't be run on an NFS client file system, because NFS
lock information is kept on the server. Lsof on the client can't
see that server kernel data.
By default the test attempts to create a file named config.LTlock<PID>,
where PID is the Process ID of the locking test process. It uses
lsof to determine if the file is on a client NFS file system. If
it is, the test aborts, hinting that the -p option can be used to
specify a non-client-NFS test file path.
This test can't be run on Darwin, because insufficient file system
lock information is available to lsof there.
Run this test:
$ ./LTlock [-p <path>]
Environment variables: LT_LSOF_PATH defines the path to the lsof
executable. (The default is ../lsof.)
G.6. LTnfs, NFS Test
====================
This is a test in the optional test group.
This test verifies that lsof can locate files mounted on a client
NFS system from an NFS server.
By default it creates a test file, config.LTnfs<PID>, where PID is
the Process ID of the test process. The test then uses lsof to
find the file on an NFS file system.
If lsof can't find the file the test warns that the test file might
not be on an NFS file system and hints that the -p option may be
used to specify the path of an NFS file, provided the test can have
read access to it there. The test warning also states that the
file at the path specified with -p must be a regular file, not a
directory.
This test can't be run on Darwin versions below 8.0, because
insufficient NFS file information is available to lsof there.
Run this test:
$ ./LTnfs [-p <path>]
Environment variables: LT_LSOF_PATH defines the path to the lsof
executable. (The default is ../lsof.)

@subnut
Copy link
Contributor

subnut commented May 9, 2022

Are you running the tests on a btrfs filesystem?
Because the same LTlock error is shown by other users running btrfs filesystem.
See #152

As expected, LTnfs isn't working because this is not a NFS filesystem.

@kloczek
Copy link
Author

kloczek commented May 9, 2022

These tests are called optional for a reason.

Not all optional tests will run in all environments. What is the environment you are testing this on?

  • Which OS?

Linux x86/64

  • What file system?

btrfs

  • Is NFS enabled on that file system?

Nope.

@subnut
Copy link
Contributor

subnut commented May 9, 2022

btrfs

LTlock failing on btrfs is being tracked on #152

This issue should be closed, IMO.

@masatake
Copy link
Contributor

masatake commented May 9, 2022

@subnut, thank you for your advice.

@masatake masatake closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants