Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holiday Policies changed? #6

Open
oaken-source opened this issue Jul 10, 2018 · 4 comments
Open

Holiday Policies changed? #6

oaken-source opened this issue Jul 10, 2018 · 4 comments

Comments

@oaken-source
Copy link

This is similar to #5.

I have received back a note from HR that "we don't work on holidays" and they will not accept an Arbeitszeitnachweis with hours clocked on a holiday.

@lsgd
Copy link
Owner

lsgd commented Jul 11, 2018

Did you double-check with the accounting department?

@oaken-source
Copy link
Author

I did. They don't know what's going on. But apparently someone in the chain of command has a problem with working hours on holidays. I have yet to find out who exactly that is.

I could probably whip up a PR to add an option to work around this by distributing more hours on other days if a working day falls on a holiday.

@lsgd
Copy link
Owner

lsgd commented Jul 18, 2018

Minijobs are covered by §2 EntgFG as well, if your regular work day is on a holiday. Berlin.de has also a flyer for that: https://www.berlin.de/ba-treptow-koepenick/_assets/beauftragte/integration/pdf/job_arbeitsrecht_geringfugige_beschaftigung.pdf

You also have some days of vacation per year... just saying.

@oaken-source
Copy link
Author

oaken-source commented Jul 27, 2018

I'm not going to start a discussion about the validity of the imaginary hours I had a program make up for me with my employer ;)

I managed to add avoiding holidays as a feature, but accidentally did a complete rewrite of the javascript code and parts of the frontend in the process - (git diff | wc -l reports something along the lines of 1500 touched lines) - I assume you don't want a commit this size as a PR, so I just pushed to a forked repo instead: https://github.com/oaken-source/hpi-stundennachweis

notable changes include:

  • use a holiday webservice instead of a manually maintained list of days
  • represent times as an integer amount of quarter hours instead of a float
  • number of months to generate is now a text input, not radio buttons
  • start time is now two text inputs (min, max), not radio buttons
  • fixed a missing </div> in the layout
  • option 'Arbeitszeit gleichmäßig verteilen' is gone (I didn't understand what that entailed)
  • option 'Feiertage vermeiden' was added

We can talk about whether and / or how these changes can be merged back, if you like, or we can just close this issue. Either way, I'm happy now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants