-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded init_clock_res #835
Conversation
sgx-lkl-musl review is here: |
Shouldn't this also remove the associated enclave_config parameter? |
@wintersteiger Should I remove the enclave_config parameter? I think you said you would do after this was done. Let me know. |
@SeanTAllen sure, go ahead and remove them if you like. There are a couple of places in the launcher and the config parser that should be removed but the compiler might not throw errors. I'm happy to take another look later or after this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@wintersteiger I removed as much as I thought needed to go and it compiles now. I'm not sure if it will pass tests or not. Can you take a look to see if I missed anything? |
16f380d
to
9a5570e
Compare
This looks perfect to me, you got all the relevant bits I think. The CI build failure is unrelated as far as I can tell, I'll try to schedule a re-run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does this mean we no longer intercept SYS_clock_getres?
sgx-lkl-musl portion has been merged. i bumped the submodule here. once it passes CI, I will squash and merge. |
Closes #816