Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: New message notification not being sent to web socket #9791

Open
anian03 opened this issue Nov 15, 2024 · 0 comments
Open

Communication: New message notification not being sent to web socket #9791

anian03 opened this issue Nov 15, 2024 · 0 comments
Labels
bug communication Pull requests that affect the corresponding module

Comments

@anian03
Copy link
Member

anian03 commented Nov 15, 2024

Describe the bug

When a new message is written to a conversation/channel that I participate in, there should be notifications about it on the web socket topic /user/topic/metis/courses/{courseId}/conversations/user/{userId} with type MetisCrudAction.NEW_MESSAGE. I found this function in the code base that is supposed to be doing this, but it doesn't seem to be called anywhere.

public void notifyAllConversationMembersAboutNewMessage(Course course, Conversation conversation, Set<User> recipients) {

Because of this, the unread indicators on the iOS app are not being updated when new messages arrive (ls1intum/artemis-ios#214).

To Reproduce

  1. Open a course's conversation page on Artemis
  2. Open the dev tools and go to the network tab
  3. Click on websocket
  4. Open the same course as another user in another tab/device
  5. Send a message to a conversation
  6. Observe that in the original tab, no message arrives in the web socket topic /user/topic/metis/courses/{courseId}/conversations/user/{userId}.
    The client is only notified about the message itself on other topics if subscribed, such as /topic/metis/courses/{courseId}.

Expected behavior

A payload with type MetisCrudAction.NEW_MESSAGE should be sent to the /user/topic/metis/courses/{courseId}/conversations/user/{userId} topic via the web socket.

Screenshots

No response

Which version of Artemis are you seeing the problem on?

7.7.1

What browsers are you seeing the problem on?

Safari

Additional context

No response

Relevant log output

No response

@anian03 anian03 added the bug label Nov 15, 2024
@github-actions github-actions bot added the communication Pull requests that affect the corresponding module label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug communication Pull requests that affect the corresponding module
Projects
None yet
Development

No branches or pull requests

1 participant