-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added myself to members, created members for hire section, added link to... #30
Conversation
… to members for hire in sidebar
<ul> | ||
<% data.hire.each do |member| %> | ||
<li class="vcard"> | ||
<a class="url" href="<%= member.url %>" title="<%= member.url %>"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for setting the title
as a URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is dictated by the directory name, currently the directory is named members-for-hire and that is the url structure.
In the LRUG thread, you wrote:
GitHub has a simple "Available for Hire" boolean field, so if there was a way for members to link their GitHub account to the LRUG site then that could work. |
{ | ||
"fn":"James R. McCarthy, LetyCo", | ||
"url":"http://lety.co/" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about some way of indicating whether recruiters may contact you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely if the user feels strongly about this they can indicate so on the site they link to. I fail to see a good reason to include more than a link to a site of your choice.
At first I thought that indicating whether you we're presently available was a good idea, but then realised that this info would go stale without constant updating on the users part, which would bring in the requirement for there to be an app or system allowing users to easily keep their status updated.
Given the small numbers involved in this it's not really worthwhile.
From what I understand of the github documentation, this boolean only allows you to apply for jobs that are listed on github (showing "appropriate" ones to you), and does not allow you to use this as a method of advertising your availability on your profile. |
Hmm, I can't see any restrictions like that in the API documentation, it seems to be part of the public /users/ API: https://developer.github.com/v3/users/ |
My bad, was looking at user documentation, not API docs (also been a long day for me). We could add a github account field (along with website and name) and inform people who have asked to be included on the list if they want to make use of this. A bit of JQuery would be able to fetch the details (email address, website, availability) |
Yeah, that sounds feasible. If it's done client-side with no way of caching the result then then you might run into problems hitting the rate limit though, I'm not sure how generous it is. |
Rate limit is not an issue until this list starts to grow quite large (with one API call per user) |
h-lame has already added me to the members list, so this is not need.
andyw8 I'm thinking that live availability via github accounts should be a separate pull request, it is additional functionality over the addition of a members for hire list (which would be the default view without Javascript, which LRUG.org currently doesn't require). I still think it should be done (and once this pull request is approved/rejected will begin working on it). |
I was chatting to @andrewmcdonough and he suggested something a bit easier to manage using google spreadsheets or something. Good to see a bunch of names on the list though, certainly suggests there's some appetite for it. I'll hold off on merging though until Andrew chips in and we see if his approach is something we want to go with. |
No probs, talk later. James.
James McCarthy Software Consultant LetyCo Mob: 07577006897 Email: [email protected] lety.co |
This is embarrassingly slow, but I'm going to close this. See discussion on #31, but basically, we're less and less convinced of the benefits of something croud-sourced like this or the existing Sorry for leaving it soooo long without any closure either way. I suspect even if we had merged it, based on the discussion in #31 we'd probably be deleting it soon along with |
Add a members for hire section to the site.
This pull request creates a members for hire section, a link to the members for hire section in the sidebar, and a list of members (in the data directory) to show there.
The pull request also includes a single addition to the members section.