Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide commit message insertion via dialog template #49

Closed
lppedd opened this issue Feb 9, 2021 · 10 comments
Closed

Provide commit message insertion via dialog template #49

lppedd opened this issue Feb 9, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lppedd
Copy link
Owner

lppedd commented Feb 9, 2021

See TextFieldWithCompletion.
Seems impossible to reuse the CompletionContributor, so we need to wire up everything again.

Idea from #35

@lppedd lppedd added the enhancement New feature or request label Feb 9, 2021
@lppedd lppedd added this to the 1.0.0 milestone Feb 9, 2021
@lppedd lppedd self-assigned this Feb 9, 2021
@lppedd
Copy link
Owner Author

lppedd commented Feb 9, 2021

Example:

image

cc @patrek

@lppedd
Copy link
Owner Author

lppedd commented Feb 11, 2021

Current state:

image

@patrek
Copy link

patrek commented Feb 11, 2021

Nice.

Don't know how difficult it is, but I would make type selectable form usual values somehow.

I would also add a field where one can enter the issue number

@lppedd
Copy link
Owner Author

lppedd commented Feb 11, 2021

@patrek as you can see from the first screenshot, you can still complete each field with completion values (usual popup).
Is that what you mean?

I would also add a field where one can enter the issue number

Yeah! I'll add the possibility of inputting a single footer.

@patrek
Copy link

patrek commented Feb 11, 2021

yes, that is perfect. I did not understand the first screen shot properly.

for the single footer, as long as the completion makes it easy to make one for the issue number, that would be perfect.

The idea is to put that in the hands of a junior developper to bring him up to speed rapidely

@lppedd
Copy link
Owner Author

lppedd commented Feb 11, 2021

Seems ok!
Then, what is still missing:

  • Footer value and footer type
  • Ability to temporarily cache the inputted values, in case the dialog is closed and reopened for whatever reason

@lppedd
Copy link
Owner Author

lppedd commented Feb 16, 2021

@patrek I will push the commits on thursday and the marketplace update on friday 😄
I used this dialog to learn about accessibility for disabled people. Sorry for the late update.

@patrek
Copy link

patrek commented Feb 16, 2021

wow! thanks!

Don't be sorry, your turn around was fast!

@lppedd
Copy link
Owner Author

lppedd commented Feb 22, 2021

Status update: I wasn't able to commit because of issues I found. The design is finished, need to fix a logic flaw.
The dialog can be opened using an action button, as per following screenshot:

image

And here is the dialog itself:

image

In 0.20.0 I'll add the possibility of inputting multiple footers.

@lppedd
Copy link
Owner Author

lppedd commented Feb 23, 2021

Implemented with commit c8928ca
Closing for now 😄

@lppedd lppedd closed this as completed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants