Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta build: DNS monitor auto add a condition #5303

Open
1 task done
ivancarlosti opened this issue Nov 3, 2024 · 3 comments · May be fixed by #5354
Open
1 task done

Beta build: DNS monitor auto add a condition #5303

ivancarlosti opened this issue Nov 3, 2024 · 3 comments · May be fixed by #5354
Labels
area:monitor Everything related to monitors bug Something isn't working
Milestone
2.0.0-beta.1

Comments

@ivancarlosti
Copy link

📑 I have found these related issues/pull requests

It's a very small UI bug:

When you create, edit or clone a DNS monitor, it auto-add a condition.

To solve this, I recommend to not add an empty condition automatically or accept the monitor to save an empty one, ignoring it.

🛡️ Security Policy

Description

New, edit or cloned DNS monitor auto-add condition:

image

👟 Reproduction steps

Create a new monitor and select "DNS" type, or edit an existent, or clone it.
It will not allow you to save before deleting the generated condition field.

👀 Expected behavior

Do not block saving process

😓 Actual Behavior

It blocks saving process

🐻 Uptime-Kuma Version

2.0.0-beta.0

💻 Operating System and Arch

Ubuntu 24.04

🌐 Browser

Chrome 130.0.6723.92

🖥️ Deployment Environment

  • Database: external mariadb
  • number of monitors: 16

📝 Relevant log output

No response
@ivancarlosti ivancarlosti added the bug Something isn't working label Nov 3, 2024
@louislam louislam added this to the 2.0.0-beta.1 milestone Nov 4, 2024
@CommanderStorm CommanderStorm added the area:monitor Everything related to monitors label Nov 4, 2024
@louislam
Copy link
Owner

louislam commented Nov 11, 2024 •
edited
Loading

It is also make me wondering what will happen if dns monitors from v1 to v2, since there is no conditions in v1. To be tested later.

@ivancarlosti
Copy link
Author

It is also make me wondering what will happen if dns monitors from v1 to v2, since there is no conditions in v1. To be tested later.

I made a v2 fresh install, so no monitor was imported, it happens creating a new, editing or cloning a v2 monitor

@Ionys320
Copy link
Contributor

Mmmmh, I can fix it, but it seems to be normal. @louislam or @CommanderStorm, if one of you can confirm me a fix is needed..

src\components\EditMonitorConditions.vue:

created() {
    if (this.model.length === 0) {
        this.addCondition();
    }
},

@Ionys320 Ionys320 linked a pull request Nov 18, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:monitor Everything related to monitors bug Something isn't working
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

feat(monitor condition): Remove the empty default condition creation Ionys320/uptime-kuma
4 participants
@louislam @Ionys320 @ivancarlosti @CommanderStorm