Improved rendering algorithms #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the pseudo-code for polystar was wrong, this also fixes that |
|
since this PR fixes some issues with existing descriptions, is it worthwhile to merge this into a 1.0.1 release? |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
b-wils
approved these changes
Nov 8, 2024
fmalita
approved these changes
Nov 10, 2024
kudanai
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New system to define algorithms for shapes.
The code is defined in python in the markdown file.
The extension renders the python code as pseudocode, with a clearer layout than the previous version
Old:
New:
You can also switch to code examples in a couple languages (currently Python and Typescript, we could add more if we need to) so it's easier for developers to understand what's going on.
Since the algorithm is defined as actual python code, I can add scripts to show the output shape so we can double check the algorithm is correct.