You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to add support for the Vantage.Generic_HVAC_RS485_Zone_CHILD object.
This object functions similarly to the Thermostat object (I have tested with THERMTEMP, GETTHERMTEMP, THERMFAN, GETTHERMFAN, THERMOP , GETTHERMOP, THERMDAY, GETTHERMDAY functions).
However the current Thermostat model inherits from the StationObject model, which includes SerialNumber and Bus fields that are not present in the Vantage.Generic_HVAC_RS485_Zone_CHILD object (you can see an example of the object in the "Additional context" field.
I have created a fork that adds a new model for the Vantage.Generic_HVAC_RS485_Zone_CHILD object. As a quick fix I changed the Thermostat model to inherit from LocationObject instead. This change allows the integration to work correctly.
However I can see that this might not be the best way to implement this as it is modifying existing models. I wanted to get your thoughts on the best way to add support for this object. I can think of 3 solutions:
Just implementing this quick fix
Duplicating the Thermostat classes in the new model
Creating another class that both the Thermostat model and the new model can inherit, which contain the classes from the original Thermostat model
Let me know your thoughts!
Also I just wanted to say thanks for creating this project, I have had a lot of fun working on this! I'm not a software developer, so apologies if this is a simple solution.
Additional context
Here is an example of the Vantage.Generic_HVAC_RS485_Zone_CHILD object.
Checklist
Describe the feature you'd like
I would like to add support for the
Vantage.Generic_HVAC_RS485_Zone_CHILD
object.This object functions similarly to the
Thermostat
object (I have tested with THERMTEMP, GETTHERMTEMP, THERMFAN, GETTHERMFAN, THERMOP , GETTHERMOP, THERMDAY, GETTHERMDAY functions).However the current
Thermostat
model inherits from theStationObject
model, which includesSerialNumber
andBus
fields that are not present in theVantage.Generic_HVAC_RS485_Zone_CHILD
object (you can see an example of the object in the "Additional context" field.I have created a fork that adds a new model for the
Vantage.Generic_HVAC_RS485_Zone_CHILD
object. As a quick fix I changed theThermostat
model to inherit fromLocationObject
instead. This change allows the integration to work correctly.However I can see that this might not be the best way to implement this as it is modifying existing models. I wanted to get your thoughts on the best way to add support for this object. I can think of 3 solutions:
Thermostat
classes in the new modelThermostat
model and the new model can inherit, which contain the classes from the originalThermostat
modelLet me know your thoughts!
Also I just wanted to say thanks for creating this project, I have had a lot of fun working on this! I'm not a software developer, so apologies if this is a simple solution.
Additional context
Here is an example of the
Vantage.Generic_HVAC_RS485_Zone_CHILD
object.And here is a link to the fork I have created for this integration:
main...MahirManghnani:aiovantage:main
The text was updated successfully, but these errors were encountered: