-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split form study details #443
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
sphinx-autobuild --port=9999 "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For examples like this where the new screenshot shows less content than the original, have you checked that the missing bits aren't referred to in the text? That is, making sure that the text doesn't talk about e.g. changing the study state when the screenshot now cuts off at the study link?
I think it's a good call to use these simpler screenshots with less content, just need to check that we didn't misplace any signposts as we do it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This was the other image I wondered about the text context for - I like the shorter screenshot, but check that the surrounding text doesn't assume that e.g. a pic of the exit url field is visible. If it does we probably just need to do some text massaging, let me know)
Summary
Fixes #327
This PR covers a few issues: