From 839bf1ef78b10ba119f6c4710403418e52d9bd98 Mon Sep 17 00:00:00 2001
From: "@micahstubbs" <git@micah.fyi>
Date: Tue, 3 Sep 2024 17:51:25 -0700
Subject: [PATCH] convetion --> convention

---
 rules/k1.js | 96 +++++++++++++++++++++++++++--------------------------
 1 file changed, 49 insertions(+), 47 deletions(-)

diff --git a/rules/k1.js b/rules/k1.js
index 6617089..3b88fa9 100644
--- a/rules/k1.js
+++ b/rules/k1.js
@@ -1,53 +1,55 @@
 /* Copyright (c) Looker Data Sciences, Inc. See https://github.com/looker-open-source/look-at-me-sideways/blob/master/LICENSE.txt */
 
-const checkCustomRule = require('../lib/custom-rule/custom-rule.js');
-const pkNamingConvention = require('./rules-lib/pk-naming-convention.js');
-
-module.exports = function(
-	project,
-) {
-	let ruleDef = {
-		$name: 'K1',
-		match: `$.model.*.view.*`,
-		ruleFn,
-	};
-	let messages = checkCustomRule(ruleDef, project, {ruleSource: 'internal'});
-
-	return {messages};
+const checkCustomRule = require("../lib/custom-rule/custom-rule.js");
+const pkNamingConvention = require("./rules-lib/pk-naming-convention.js");
+
+module.exports = function (project) {
+  let ruleDef = {
+    $name: "K1",
+    match: `$.model.*.view.*`,
+    ruleFn,
+  };
+  let messages = checkCustomRule(ruleDef, project, { ruleSource: "internal" });
+
+  return { messages };
 };
 
 function ruleFn(match, path, project) {
-	let view = match;
-
-	const unique = (x, i, arr) => arr.indexOf(x) === i;
-
-	/* Skip field-only views */
-	if (!view.derived_table && !view.sql_table_name) {
-		return {
-			level: 'verbose',
-			description: `Field-only view ${view.$name} is not subject to Primary Key Dimension rule K1`,
-		};
-	}
-
-	let pkDimensions = (Object.values(view.dimension || {})).filter(pkNamingConvention);
-
-	if (!pkDimensions.length) {
-		return `View ${view.$name} has no dimensions that follow the PK naming convetion`;
-	}
-
-	let declaredNs = pkDimensions
-		.map(pkNamingConvention)
-		.map((match) => match[1].replace('pk', ''))
-		.map((n) => (n===''?'1':n))
-		.filter(unique);
-	if (declaredNs.length > 1) {
-		return `Different PK dimensions in ${view.$name} declare different column counts: ${declaredNs.join(', ')}`;
-	}
-
-	let n = parseInt(declaredNs[0]);
-	if (n != pkDimensions.length && n !== 0) {
-		return `View ${view.$name} has ${pkDimensions.length} PK dimension(s) but their names declare ${declaredNs[0]} columns`;
-	}
-
-	return true;
+  let view = match;
+
+  const unique = (x, i, arr) => arr.indexOf(x) === i;
+
+  /* Skip field-only views */
+  if (!view.derived_table && !view.sql_table_name) {
+    return {
+      level: "verbose",
+      description: `Field-only view ${view.$name} is not subject to Primary Key Dimension rule K1`,
+    };
+  }
+
+  let pkDimensions = Object.values(view.dimension || {}).filter(
+    pkNamingConvention
+  );
+
+  if (!pkDimensions.length) {
+    return `View ${view.$name} has no dimensions that follow the PK naming convention`;
+  }
+
+  let declaredNs = pkDimensions
+    .map(pkNamingConvention)
+    .map((match) => match[1].replace("pk", ""))
+    .map((n) => (n === "" ? "1" : n))
+    .filter(unique);
+  if (declaredNs.length > 1) {
+    return `Different PK dimensions in ${
+      view.$name
+    } declare different column counts: ${declaredNs.join(", ")}`;
+  }
+
+  let n = parseInt(declaredNs[0]);
+  if (n != pkDimensions.length && n !== 0) {
+    return `View ${view.$name} has ${pkDimensions.length} PK dimension(s) but their names declare ${declaredNs[0]} columns`;
+  }
+
+  return true;
 }