Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-batch plugin working with grails 2.4.2 and springBatch 3.0.0.RELEASE #22

Open
xmlking opened this issue Jun 30, 2014 · 6 comments

Comments

@xmlking
Copy link

xmlking commented Jun 30, 2014

I was able to upgrade libs to latest springBatch and Grails 2.4.x. it works for me with 2.4.3 grails project. (@infinumllc 's test cases need some fix to make it pass with Grails 2.4.x)

just sharing info if incase somebody wants to use this plugin with Grails 2.4.x

https://github.com/xmlking/grails-spring-batch
spring Batch update 2.1.9.RELEASE => 3.0.0.RELEASE
spring Batch Admin update 1.2.2.RELEASE => 1.3.0.BUILD-RELEASE

I added URL mapping to secure plugin controllers with spring security.

Here is my demo app that is using this modified plugin
https://github.com/xmlking/grails-batch-rest

@danieldbower
Copy link
Collaborator

Are you using this in an environment for which you've been able to run it for a bit and smoke out any bugs? I'll publish it if you have.

@xmlking
Copy link
Author

xmlking commented Mar 4, 2015

I haven't seen any issues. Was able to run jobs via Amin UI.

@danieldbower
Copy link
Collaborator

Okay, thanks, I'll try to merge it in sometime soon then.

@longwa
Copy link
Owner

longwa commented Mar 15, 2016

This is pretty old but we started using Spring batch in 2.5.4 so I decided to revisit. There's some breaking API changes but I have a branch working with 3.0.6 and Grails 2.5.4. All of the unit tests run and all of the jobs in both test projects work properly including the UI.

The only other change I made was to remove the usage of platform-core which is basically a defunct plugin and not ported to 3.0 (I went ahead and removed it even in my 2.5.x version since it was super easy to remove and I had originally intended to move to 3.0 but wasn't able to go there yet).

I can submit a pull request if someone will merge it. I pushed the version to 2.5.0 to (sort of) reflect the Grails version.

Soon I can upgrade this plugin to Grails 3 as well.

@danieldbower
Copy link
Collaborator

I would recommend submitting the pull request, or even volunteering for collaborator status :-)

@longwa
Copy link
Owner

longwa commented Mar 16, 2016

I don't mind being a collaborator. Once we start using the plugin, it will be nice to keep it up to date for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants