Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoValue using async functions #484

Open
bratelefant opened this issue Apr 9, 2023 · 2 comments
Open

AutoValue using async functions #484

bratelefant opened this issue Apr 9, 2023 · 2 comments

Comments

@bratelefant
Copy link

Hi,

the AutoValueRunner doesn't seem to be able to use async functions. For upcoming changes to Meteor 3.0 this could be crucial imho.

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Thank you for submitting an issue!

If this is a bug report, please be sure to include, at minimum, example code showing a small schema and any necessary calls with all their arguments, which will reproduce the issue. Even better, you can link to a saved online code editor example, where anyone can immediately run the code and see the issue.

If you are requesting a feature, include a code example of how you imagine it working if it were implemented.

If you need to edit your issue description, click the [...] and choose Edit.

Be patient. This is a free and freely licensed package that I maintain in my spare time. You may get a response in a day, but it could also take a month. If you benefit from this package and would like to see more of my time devoted to it, you can help by sponsoring.

@aldeed
Copy link
Collaborator

aldeed commented Feb 26, 2024

It's tempting to add async support, but potentially hard or impossible to do without breaking support for form submission validation in browsers, which must be synchronous. In the past I have said that autoValue isn't a good solution when you can't do it synchronously, and I tend to think that's probably still true. If someone wants to attempt a PR that adds a separate autoValueAsync option, I would consider merging it. But I'm not sure it is possible to do this without making the rest of the validation flow async and breaking form submission validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants