Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchModes do not take availability of intermediate dates into account #153

Open
holtkamp opened this issue Aug 31, 2015 · 1 comment
Open
Labels
Status: todo Accepted issue that needs someone to fix it. Type: bug Valid bug introduced in new features, confirmed by a contributor.

Comments

@holtkamp
Copy link
Collaborator

Current situation
When using batchMode = 'week' and suppose the week Monday 07-09-2015 to Sunday 13-09-2015, has an intermediate day such as Friday 18-09-2015 which is not available (realised by having the function defined for beforeShowDay return false). I can still click the Monday 07-09-2015, which eventually results in the complete week selected, including the non-available days.
20150831_selectweekwithdisableddates_01
20150831_selectweekwithdisableddates_02

Expected situation
In case an intermediate day of a certain batch is not available, then this batch should also not be allowed to be indicated. So all intermediate dates should be considered as well when determining whether to 'allow' the range selection or not.

@monovertex monovertex added Type: bug Valid bug introduced in new features, confirmed by a contributor. Status: todo Accepted issue that needs someone to fix it. Category: help wanted Good issue for beginners. and removed Category: help wanted Good issue for beginners. labels Sep 19, 2018
@monovertex
Copy link
Collaborator

This bug appears with every action that allows you to select multiple days at once. See #468 for another example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: todo Accepted issue that needs someone to fix it. Type: bug Valid bug introduced in new features, confirmed by a contributor.
Projects
None yet
Development

No branches or pull requests

2 participants