New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS bug fixed that the docs were referencing #1649

Open

Swahvay opened this issue Sep 13, 2023 · 3 comments · Fixed by #1651

Contributor

Swahvay commented Sep 13, 2023

In https://ent.dev/docs/custom-graphql/gql-object-type there is a reference to a TS bug, saying

Until this bug is fixed, custom objects need to be defined in a separate file from where they're consumed.

That bug has been fixed.

Contributor Author

Swahvay commented Sep 13, 2023

Actually https://ent.dev/docs/custom-graphql/gql-input-object-type, https://ent.dev/docs/custom-graphql/gql-interface-type, and https://ent.dev/docs/custom-graphql/gql-union-type also make the same reference.

lolopinto mentioned this issue

remove reference to fixed bug #1651

Merged

lolopinto closed this as completed in #1651

Owner

lolopinto commented Sep 14, 2023

will revert because still seems broken in 5.2.2: https://github.com/lolopinto/ent/compare/move-custom-types?expand=1

lolopinto reopened this

lolopinto mentioned this issue

Revert "remove reference to fixed bug (#1651)" #1653

Merged

Contributor Author

Swahvay commented Sep 15, 2023

Nuts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment