From aad27250ab04e03bbfb1aac531a1c628d3db23aa Mon Sep 17 00:00:00 2001 From: Travis Cline Date: Sun, 17 Jun 2018 17:27:32 -0700 Subject: [PATCH] [errors] address a few todos --- src/sybil/column_store_io.go | 2 -- src/sybil/table_ingest.go | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/sybil/column_store_io.go b/src/sybil/column_store_io.go index 432a5175..92bab36a 100644 --- a/src/sybil/column_store_io.go +++ b/src/sybil/column_store_io.go @@ -483,7 +483,6 @@ func (tb *TableBlock) SaveToColumns(filename string) error { // TODO: if nb == nil || nb.Info.NumRecords != int32(len(tb.RecordList)) { - // TODO//Error("COULDNT VALIDATE CONSISTENCY FOR RECENTLY SAVED BLOCK!", filename) return fmt.Errorf("could not validate consistency for recently saved block %v", filename) } @@ -493,7 +492,6 @@ func (tb *TableBlock) SaveToColumns(filename string) error { return err } if nb == nil || len(nb.RecordList) != len(tb.RecordList) { - // TODO//Error("DEEP VALIDATION OF BLOCK FAILED CONSISTENCY CHECK!", filename) return fmt.Errorf("deep validation of block failed consistency check %v", filename) } } diff --git a/src/sybil/table_ingest.go b/src/sybil/table_ingest.go index 1e5bafd2..6cd81169 100644 --- a/src/sybil/table_ingest.go +++ b/src/sybil/table_ingest.go @@ -2,7 +2,6 @@ package sybil import ( "io/ioutil" - "log" "os" "path" "strings" @@ -42,8 +41,7 @@ func (t *Table) IngestRecords(blockname string) error { } t.newRecords = make(RecordList, 0) if err := t.SaveTableInfo("info"); err != nil { - //return errors.Wrap(err, "t.SaveTableInfo") - log.Println(err) + Warn(errors.Wrap(err, "t.SaveTableInfo")) } t.ReleaseRecords()