Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development playground #4935

Open
genu opened this issue Nov 10, 2024 · 3 comments
Open

Add development playground #4935

genu opened this issue Nov 10, 2024 · 3 comments

Comments

@genu
Copy link
Contributor

genu commented Nov 10, 2024

Is your feature request related to a problem? Please describe.

When contributing, It would be great if there was a playground built in to easily get a development environment setup and start working.

Currently there's only a way to build and run tests/coverage

I'd like an easier way to contribute, or a documented way to get things up and running fast.

Describe the solution you'd like

I'd like to be able to clone the repo, run something like pnpm dev and be able to start testing changes in the vee-validate package.

Describe alternatives you've considered

Having made contributions, I had to create my own playground, install the package from npm, modify the built package in node_modules and then copy my changes back into the src of vee-validate

@logaretm
Copy link
Owner

logaretm commented Nov 11, 2024

I did a similar thing in other projects, should we add a playground vite Vue app to the packages? would that be fine? What would you like to have in that app to make things faster/easier?

My current workflow is building + pnpm link -g which is a bit involved and isn't as fast as having a Playground app.

@genu
Copy link
Contributor Author

genu commented Nov 11, 2024

what about a playground in the root rather than in packages since the playground wouldn't be published to npm. it could be a simple vite/vue app set up with the vee-validate package.

To make things faster, I would like to be able to run pnpm dev from the root which would start a dev server with the playground, but also hot reload the vee-validate package so that changes can be done in the lib and have it hot-reloaded in the playground.

Either that, or have the dev-server restarted whenever the vee-validate package changes.

@logaretm
Copy link
Owner

since the playground wouldn't be published to npm

That's not going to be an issue, we can exclude it just like with the shared pkg.

To make things faster, I would like to be able to run pnpm dev from the root which would start a dev server with the playground.

Sure, easily doable. I will try to put it together today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants