update pascal-case to accept acronyms #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope your use of the unicode library wasn't targeting something in a non-Latin language that my regex now misses, but the existing test cases didn't point out anything I should be worried about. |
|
Hey @jfairley, thank you for your contribution! Really appreciate that! There are plenty reasons because this isn't mergable:
<3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the PascalCase validator to be regex-based, and allows names that include acronyms of any length.
Technically, this means that
PASCALCASEis valid PascalCase. I don't personally think it's wrong though, just odd.I'm hoping your CI will run tests for me. I don't have go set up on my local machine, but I think what I did is valid. 😁
close #67