New architecture support

[PopJoestar]

Hello, does this work with new architecture?

[lodev09]

Not yet unfortunately. There are some blockers on interop layer when using swift. Or I'm missing something.
Either way, just gonna hold on for a bit until new arc becomes stable

[Martin2037]

Really like this project💗
New arch works fine with swift, check out turbo swift

Need New Arch Support～～～

[lodev09]

Yeah it can run on swift with new arch and bridgeless mode enabled but the touch handler is not working 😢

Also, it needed Fiber support and Swift isn't supported yet.

The only option at this point is to convert the whole IOS lib to Objective-C for it to work with the interop layer and ultimately support FIber. So I'm holding on for a bit, maybe they will release support Swift soon

[vbylen]

Yeah it can run on swift with new arch and bridgeless mode enabled but the touch handler is not working 😢

Also, it needed Fiber support and Swift isn't supported yet.

The only option at this point is to convert the whole IOS lib to Objective-C for it to work with the interop layer and ultimately support FIber. So I'm holding on for a bit, maybe they will release support Swift soon

Hmm that's unfortunate. This was my favorite modal library for react native 😭

[lodev09]

Yeah. Can't do anything about it since it's a missing feature from RN. I wanted to support new arch badly. If next version does not support it still, I'll have to convert ios to objective-c :D

[lodev09]

Created issue at RN. hopefully they can give more insight. 🙏

[lodev09]

Good news.. looks like we will be supporting New Arch really soon! I'll just wait for expo to update RN with the guy's PR 🚀

[gorbypark]

I'm playing around with the Expo SDK52 beta with new arch enabled by default. Came across this because buttons/pressables are not working 😅

Do we know if the PR to the interop layer on the RN side of things landed? Expo 52 is using react native 0.76.0.

[ReactorCSA]

Hi @lodev09!

How is the progress fixing Touchables on Android? Sorry for pushing but I am really waiting the fix so hard

[lodev09]

I can only work on it on my free time. I'm kinda busy with other things :/
Sorry.

[ReactorCSA]

Hi @lodev09 !

Do you have any progress regarding adapting your library to new arch?

[dinosmajovic]

So excited to use it with new arch

[lodev09]

Hey, please check PR #106. I've made some changes to this lib to work on New Arch thru the interop layer. It's not fully Fabric yet (see discussion above) but hopefully this works in the meantime!

Thanks!

[sajorahasan]

With new architecture enabled in expo 52 stable, I keep getting app crash on android

Here is crash log:

msg: java.lang.UnsupportedOperationException: EventEmitter#receiveTouches is not supported by the Fabric Interop Layer
--
  | stacktrace: java.lang.UnsupportedOperationException: EventEmitter#receiveTouches is not supported by the Fabric Interop Layer
  | at com.facebook.react.internal.interop.InteropEventEmitter.receiveTouches(InteropEventEmitter.kt:47)
  | at com.facebook.react.uimanager.events.TouchesHelper.sendTouchesLegacy(TouchesHelper.java:107)
  | at com.facebook.react.uimanager.events.ReactEventEmitter.receiveTouches(ReactEventEmitter.java:92)
  | at com.facebook.react.uimanager.events.TouchEvent.dispatchModern(TouchEvent.kt:124)
  | at com.facebook.react.uimanager.events.FabricEventDispatcher.dispatchEvent(FabricEventDispatcher.java:76)
  | at com.facebook.react.uimanager.JSTouchDispatcher.handleTouchEvent(JSTouchDispatcher.java:97)
  | at com.facebook.react.uimanager.JSTouchDispatcher.handleTouchEvent(JSTouchDispatcher.java:68)
  | at com.lodev09.truesheet.core.RootSheetView.onInterceptTouchEvent(RootSheetView.kt:102)
  | at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2659)
  | at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
  | at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2749)
  | at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
  | at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2749)
  | at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
  | at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2749)
  | at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
  | at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2749)
  | at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
  | at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2749)
  | at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
  | at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2749)
  | at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
  | at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2749)
  | at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
  | at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2749)
  | at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:496)
  | at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1953)
  | at android.app.Dialog.dispatchTouchEvent(Dialog.java:933)
  | at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:70)
  | at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:454)
  | at android.view.View.dispatchPointerEvent(View.java:16548)
  | at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:7586)
  | at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:7348)
  | at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6745)
  | at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6802)
  | at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6768)
  | at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:6934)
  | at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6776)
  | at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6991)
  | at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6749)
  | at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6802)
  | at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6768)
  | at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6776)
  | at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6749)
  | at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:9854)
  | at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:9805)
  | at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:9774)
  | at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:9996)
  | at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:295)
  | at android.os.MessageQueue.nativePollOnce(Native Method)
  | at android.os.MessageQueue.next(MessageQueue.java:349)
  | at android.os.Looper.loopOnce(Looper.java:189)
  | at android.os.Looper.loop(Looper.java:317)
  | at android.app.ActivityThread.main(ActivityThread.java:8592)
  | at java.lang.reflect.Method.invoke(Native Method)
  | at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
  | at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)

[ferdinanddoremus]

Thanks @lodev09 , any plan on officially releasing it since it is merged on main now?

[lodev09]

I'm currently testing it on one of my production app. I'll release once it's stable :)

[codydorsettlynn]

Any chance of a canary tagged release in the meantime?

[ReactorCSA]

Currently I'm testing it directly applying dependency as follows:
"@lodev09/react-native-true-sheet": "lodev09/react-native-true-sheet#main",
It works completely fine! @lodev09 thank you for your hard work!