Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent field to set breadcrumbs #107

Open
willguv opened this issue Aug 2, 2024 · 6 comments · May be fixed by #128
Open

Add parent field to set breadcrumbs #107

willguv opened this issue Aug 2, 2024 · 6 comments · May be fixed by #128
Assignees

Comments

@willguv
Copy link
Member

willguv commented Aug 2, 2024

Newcastle has noted it's not possible to include elections within a page hierachy

This page https://new.newcastle.gov.uk/election/uk-parliamentary-general-election-4-july-2024 sits at the top level

We need a parent field or similar to allow breadcrumbs to be set

@willguv willguv added this to Elections Aug 2, 2024
@willguv willguv converted this from a draft issue Aug 2, 2024
@markconroy markconroy linked a pull request Aug 16, 2024 that will close this issue
@finnlewis
Copy link
Member

Discussing briefly in merge Tuesday.

It'd be good to explore what type of 'parent' we want to cater for.

Service landing pages come with additional features (announcing itself to become a child page).

If we want to have a parent field solely to generate inherited path alias and breadcrumbs, maybe we want a different approach here?

@willguv
Copy link
Member Author

willguv commented Aug 21, 2024

Hi @finnlewis, am copying in @Mjeffbrown who's our only user of Elections so far.

Michael, was your expectation to include Elections within a service hierarchy?

Thanks both

@finnlewis
Copy link
Member

@willguv wants to check where we want to put elections.

@github-project-automation github-project-automation bot moved this from Next to Done in Elections Aug 27, 2024
@finnlewis finnlewis reopened this Aug 27, 2024
@Mjeffbrown
Copy link

We have an elections information section - https://new.newcastle.gov.uk/council-elections/elections-voting/

It would be useful to sit Elections pages under their relevant page (or at least have a breadcrumb that makes it appear they do) - Whether that is our Upcoming Elections page, or perhaps once an election has passed, moving them to sit under some kind of Previous Elections archive.

Open to any suggested approaches. Thanks.

@willguv
Copy link
Member Author

willguv commented Sep 2, 2024

Hi @Mjeffbrown it looks like the Election is made up of service landing pages. Is this right? Thanks

@Mjeffbrown
Copy link

Elections and Voting is a Service Landing Page and then it's Guide pages beneath that (so Upcoming Elections is a Guide Overview, General Elections is a Guide Page, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants