You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is not really an issue, more a comment on why I ended up not using this library.
I want the constants to help me avoid mistakes, one of these mistakes is using a Request header in a Response request or vice versa, since all the headers are joined in one class this prevents me from being able to do that.
Hi, this definitely makes sense and I'm for this change. To provide upgrade path, all constants in Header could be kept, but those which are also in Request or Response would be marked as deprecated.
@timohuovinen Are you interested in making this happen?
OndraM
changed the title
Just a comment
Separate Request and Response header constants
Nov 2, 2020
This is not really an issue, more a comment on why I ended up not using this library.
I want the constants to help me avoid mistakes, one of these mistakes is using a Request header in a Response request or vice versa, since all the headers are joined in one class this prevents me from being able to do that.
I prefer the way that mozilla suggests to organize headers RequestHeader, ResponseHeader and GenericHeader (Though I'd just repeat Generic in Request and Response)
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers
The text was updated successfully, but these errors were encountered: