Skip to content

Commit

Permalink
Set CI=true in all workflows
Browse files Browse the repository at this point in the history
As all the warnings on the build are now fixed (thx to opencast#430), we no
longer need to set `CI=false` to actively suppress warnings to be
picked up by our CI tests. This should help with us not introducing new
warnings.
  • Loading branch information
lkiesow committed May 31, 2024
1 parent 7d84ae0 commit 1c5abde
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/deploy-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ jobs:
run: npm ci

- name: build project
env:
CI: false
run: npm run build

- name: create pages directory
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/deploy-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,9 @@ jobs:
run: npm ci

- name: build app
run: npm run build
env:
PUBLIC_URL: /${{ steps.build-path.outputs.build }}
CI: false
run: npm run build

- name: prepare git
run: |
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,4 @@ jobs:
run: npm ci

- name: build project
env:
CI: false
run: npm run build

0 comments on commit 1c5abde

Please sign in to comment.