Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_makefile generates bad 'find' command, 'echo -e' interacts badly with dash shell. #4

Open
colmbuckley opened this issue Aug 4, 2020 · 0 comments

Comments

@colmbuckley
Copy link

Under some circumstances, the v4l/scripts/make_makefile.pl script can generate a 'find' command with bad arguments, resulting in a flood of error messages on make install. This only affects the removeubuntu function to remove installed files from Ubuntu/Debian locations. Replacing -name in the generated commands with -path addresses the issue.

Further, echo -e does not work correctly with the "dash" shell; as -e is not a supported flag in this shell. Replacing the echo -e with printf addresses this issue.

Proposed patch attached.
make_makefile.patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant