From 47f395e295038cb569f4ae233bc27bb26bc73694 Mon Sep 17 00:00:00 2001 From: Ali Lloyd Date: Wed, 13 May 2020 13:49:14 +0100 Subject: [PATCH 1/2] [[ Bug 22285 ]] Restrict selection of key field in customprops editor This patch ensures that the key field of the custom properties editor in the property inspector is only selected in response to a change in the tree view hilite. --- .../com.livecode.pi.customprops.behavior.livecodescript | 9 +++++++-- notes/bugfix-22285.md | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 notes/bugfix-22285.md diff --git a/Toolset/palettes/inspector/editors/com.livecode.pi.customprops.behavior.livecodescript b/Toolset/palettes/inspector/editors/com.livecode.pi.customprops.behavior.livecodescript index eb9a46534b..499c3b0dc0 100644 --- a/Toolset/palettes/inspector/editors/com.livecode.pi.customprops.behavior.livecodescript +++ b/Toolset/palettes/inspector/editors/com.livecode.pi.customprops.behavior.livecodescript @@ -1,8 +1,9 @@ script "com.livecode.pi.customprops.behavior" -local sPropSet, sHilitePath +local sPropSet, sHilitePath, sReselect on editorInitialize put empty into sPropSet + put false into sReselect put the editorLabel of me into field "rowlabel" of me set the rowShowLabel of me to false set the label of button "customPropertySet" of group "Set buttons" of me to "customKeys" @@ -69,7 +70,10 @@ on editorUpdate if the result is empty then put tKey into field "value" of me put item -1 of tPath into field "key" of me - select the text of field "key" of me + if sReselect then + select the text of field "key" of me + put false into sReselect + end if else put empty into field "key" of me put empty into field "value" of me @@ -371,6 +375,7 @@ function revValidSetName pWhich end revValidSetName on hiliteChanged + put true into sReselect checkRehilite editorUpdate put empty into sHilitePath diff --git a/notes/bugfix-22285.md b/notes/bugfix-22285.md new file mode 100644 index 0000000000..b9a1affae4 --- /dev/null +++ b/notes/bugfix-22285.md @@ -0,0 +1 @@ +# Only reselect key field in customprops editor in response to a change in hilite From 394910d79dd6c8b4f25e8867286c489841be01ad Mon Sep 17 00:00:00 2001 From: mikey Date: Thu, 25 Jun 2020 10:34:27 -0400 Subject: [PATCH 2/2] fix delayTouches library sets delayTouches to false which will mean that scrolling a dg will be impossible, because the moment the dg is touched a row will be selected. --- .../behaviorsdatagridbuttonbehavior.livecodescript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Toolset/palettes/revdatagridlibrary/behaviorsdatagridbuttonbehavior.livecodescript b/Toolset/palettes/revdatagridlibrary/behaviorsdatagridbuttonbehavior.livecodescript index d4bb2f4402..cdd0d12628 100644 --- a/Toolset/palettes/revdatagridlibrary/behaviorsdatagridbuttonbehavior.livecodescript +++ b/Toolset/palettes/revdatagridlibrary/behaviorsdatagridbuttonbehavior.livecodescript @@ -368,7 +368,7 @@ private command _CreateMobileScroller mobileControlSet sScrollerId, "canBounce", "true" mobileControlSet sScrollerId, "pagingEnabled", "false" mobileControlSet sScrollerId, "canScrollToTop", "true" - mobileControlSet sScrollerId, "delayTouches", "false" + mobileControlSet sScrollerId, "delayTouches", "true" mobileControlSet sScrollerId, "canCancelTouches", "true" __PollVisibility end if