From 2f9bb4ad661f08262e4b7afa06167c12fce0d280 Mon Sep 17 00:00:00 2001 From: livecodepanos Date: Tue, 15 Oct 2019 14:53:58 +0300 Subject: [PATCH] [[ Bug 22211 ]] Remove unnecessary 'unlock cursor' in ideMouseMove This patch removes a seemingly unnecessary `unlock cursor` in the IDE's mouseMove event handler (`ideMouseMove`). The IDE intercepts mouseMove so that it can update the resize cursor used when the mouse is over the relevant selection handlers. It does this by locking the cursor in this case and then changing the cursor appropriately; unlocking the cursor when there is a selected object and the mouse is not over a selection handle. Previously it would also unlock the cursor if pointer tool was in effect and there was no selected object which (because the handler is executed in time after any user handlers) would undo any user use of `lock cursor`. --- Toolset/libraries/revbackscriptlibrary.livecodescript | 2 -- notes/bugfix-22211.md | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) create mode 100644 notes/bugfix-22211.md diff --git a/Toolset/libraries/revbackscriptlibrary.livecodescript b/Toolset/libraries/revbackscriptlibrary.livecodescript index ee072a96e3..f90a145d86 100644 --- a/Toolset/libraries/revbackscriptlibrary.livecodescript +++ b/Toolset/libraries/revbackscriptlibrary.livecodescript @@ -3335,8 +3335,6 @@ on ideMouseMove pX, pY, pTarget else unlock cursor end if - else - unlock cursor end if end ideMouseMove diff --git a/notes/bugfix-22211.md b/notes/bugfix-22211.md new file mode 100644 index 0000000000..41ec175c18 --- /dev/null +++ b/notes/bugfix-22211.md @@ -0,0 +1 @@ +# Ensure lock cursor does not break when the pointer tool is selected