Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3554): correct module_to_os_path to return directory paths #3565

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

supercoder-dev
Copy link
Contributor

To resolve the issue, we need to update the module_to_os_path function to check if the found path is a file. If it is, we should return the parent directory instead. This can be done by using Path(src.origin).parent if src.origin is a file.

@supercoder-dev supercoder-dev requested review from a team as code owners June 12, 2024 11:05
@provinzkraut provinzkraut changed the title Issue 3554 resolved fix: #3554 Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (5223d2d) to head (e9d8cfc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3565   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         329      329           
  Lines       14965    14965           
  Branches     2382     2382           
=======================================
  Hits        14708    14708           
  Misses        116      116           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacobCoffee JacobCoffee changed the title fix: #3554 fix(#3554): correct module_to_os_path to return directory paths Jun 13, 2024
@JacobCoffee JacobCoffee changed the title fix(#3554): correct module_to_os_path to return directory paths fix(#3554): correct module_to_os_path to return directory paths Jun 13, 2024
@JacobCoffee JacobCoffee changed the title fix(#3554): correct module_to_os_path to return directory paths fix(#3554): correct module_to_os_path to return directory paths Jun 13, 2024
@cofin cofin enabled auto-merge (squash) August 25, 2024 01:05
@cofin
Copy link
Member

cofin commented Aug 25, 2024

@all-contributors, add @supercoder-dev for bugs, code

@cofin cofin merged commit b1f7134 into litestar-org:main Aug 25, 2024
24 checks passed
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants